Repository navigation
Add newsletter image upload CLI/API, course banner resolution, and sponsor graphic auto-insert - #444
Merged
alexeygrigorev merged 2 commits intoNov 13, 2026
Conversation
…r graphic auto-insert
… migration script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/newsletter-issues/:id/imagesreusingsavePublicImage(with full image decode and dimension validation from PR Validate sponsor graphic uploads, remove silent 300k slice, and alert on failures #440) to store durable public newsletter images in S3 (/api/public-images/:id).dataops newsletter image upload <issue-id> <path>CLI command (with--helpandcli/skill/SKILL.mddocs) that uploads an image and prints its durable publichttps://URL.backend/src/newsletter/markdownPreview.tsto:[](href)) as clickable<figure>elements.[Banner: Course name]markers (AI Dev Tools Zoomcamp,Machine Learning Zoomcamp) to their public course banners without inventing missing banners (Production AI Agents for Generative Media, event posters, recording thumbnails).graphicsUrlwith its trackedctaUrlinto theSPONSOREDblock of the newsletter issue preview when no image is already present.cli/scripts/migrate-sponsor-doc-images.mjsto migratedata:image/...;base64,...sponsorgraphicsUrlvalues to hosted storage (and support--replace <doc-id>=<path>for truncated legacy uploads).Test Plan
NODE_ENV=test FRONTEND_ROOT=../frontend SKIP_AUTH=true node --import tsx --test backend/tests/newsletter-markdown.test.ts backend/tests/public-images.test.ts(6/6 passing)npm --prefix backend run typecheck(passing)npm --prefix cli test(613/613 passing)